]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
Revert "serial: imx: always wake up the processes in the TX callback"
authorJiada Wang <jiada_wang@mentor.com>
Tue, 9 Dec 2014 09:11:29 +0000 (18:11 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 9 Jan 2015 22:23:07 +0000 (14:23 -0800)
commitd64b8607aceb9bd3b3dabddfc4f76458e5a8489d
tree12a74a895defc98a81441333bcedfd8c776031f4
parent42f752b3fbcfee9c27e4f6f6216e60e130ba98c8
Revert "serial: imx: always wake up the processes in the TX callback"

This reverts commit 2ad28e3efee21a5bbf940c83d1f0395b76bd3efb.

Instead of always wake up write_wait process in TX callback,
TX callback should call imx_dma_tx() again, and let imx_dma_tx
transfer the remaining data in circle buffer.

The issue with commit 2ad28e3 is, in case there is remaining
data in circle buffer, but no process is waiting on write_wait
queue, then as no following uart_write() will be called after
uart_write_wakeup(), thus cause data loss.

Moreover according to Documentation/serial/driver, uart_write_wakeup()
should be called in case the transmit buffer have dropped below
a threshold.

Signed-off-by: Jiada Wang <jiada_wang@mentor.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/imx.c