]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
powerpc/cell/iommu: Add missing of_node_put
authorJulia Lawall <julia@diku.dk>
Sun, 21 Aug 2011 06:10:00 +0000 (06:10 +0000)
committerBenjamin Herrenschmidt <benh@kernel.crashing.org>
Fri, 25 Nov 2011 03:11:27 +0000 (14:11 +1100)
commitdbfc189cc59adb2150e7e7b461d73e5a40e1158c
tree6e149f63a10786fdb4638164b62dfea51ebe3bae
parent8d3d589a7901dd93743e98a60a0bacde485437f3
powerpc/cell/iommu: Add missing of_node_put

np is initialized to the result of calling a function that calls
of_node_get, so of_node_put should be called before the pointer is dropped.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression e,e1,e2;
@@

* e = \(of_find_node_by_type\|of_find_node_by_name\)(...)
  ... when != of_node_put(e)
      when != true e == NULL
      when != e2 = e
  e = e1
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
arch/powerpc/platforms/cell/iommu.c