]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
rocker: make rocker_port_internal_vlan_id_{get, put}() non-transactional
authorSimon Horman <simon.horman@netronome.com>
Thu, 21 May 2015 03:40:17 +0000 (12:40 +0900)
committerDavid S. Miller <davem@davemloft.net>
Thu, 21 May 2015 21:20:55 +0000 (17:20 -0400)
commitdf6a20673011e89f7fbe3d667eee0a9550679841
tree338bdd1e6d8a5ddd231c36d10588d353be52193b
parent550ecc92feb10fdb7ab1d052707b11bca955de5f
rocker: make rocker_port_internal_vlan_id_{get, put}() non-transactional

The motivation for this is that rocker_port_internal_vlan_id_{get,put} appear
to only partially implement the transaction model: memory allocation
and freeing is transactional, but hash and bitmap manipulation is not.

The latter could be fixed, however, as it is not currently exercised
due to trans always being SWITCHDEV_TRANS_NONE it seems cleaner
to make rocker_port_internal_vlan_id_get non-transactional.

This problem was introduced by c4f20321d968 ("rocker: support
prepare-commit transaction model").

Found by inspection.
I do not believe that this change should have any run-time effect.

Acked-by: Scott Feldman <sfeldma@gmail.com>
Acked-by: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: Simon Horman <simon.horman@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/rocker/rocker.c