]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
iwlwifi: mvm: simplify iwl_mvm_get_wakeup_status() return
authorJohannes Berg <johannes.berg@intel.com>
Tue, 3 Mar 2015 19:23:47 +0000 (20:23 +0100)
committerEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Thu, 12 Mar 2015 07:57:49 +0000 (09:57 +0200)
commite111e9685790ccd9acce5de51fa7ed6b9ae8a746
tree0d22b971df368538bc221242d2cc8d68c6b7ec9d
parent0c2ae049aef7fe1b8800db3f28c23520150bfd78
iwlwifi: mvm: simplify iwl_mvm_get_wakeup_status() return

The return value in iwl_mvm_get_wakeup_status() is a bit unclear in
that it's not obvious that we don't leak fw_status in some cases.
Use fw_status directly with ERR_PTR() and return only it, that way
the compiler has a chance of proving that it's uninitialized (if it
ever is due to new changes.)

Additionally, this removes a smatch warning since smatch couldn't
figure out that fw_status can't, in fact, leak here.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
drivers/net/wireless/iwlwifi/mvm/d3.c