]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
PCI: Revert aeb30016fec3 ("PCI: add Intel USB specific reset method")
authorBjorn Helgaas <bhelgaas@google.com>
Wed, 24 Jun 2015 20:46:38 +0000 (15:46 -0500)
committerBjorn Helgaas <bhelgaas@google.com>
Tue, 14 Jul 2015 18:40:11 +0000 (13:40 -0500)
commiteefaf338820ecd3fb14da496f8a740612257a341
tree39cdf37d303eec70a3de68594051d3d5601d2996
parentd1541dc977d376406f4584d8eb055488655c98ec
PCI: Revert aeb30016fec3 ("PCI: add Intel USB specific reset method")

Revert aeb30016fec3 ("PCI: add Intel USB specific reset method").

We checked for "dev->class == PCI_CLASS_SERIAL_USB", but dev->class
contains the entire three-byte base class/sub-class/interface, while
PCI_CLASS_SERIAL_USB is only the two-byte base class/sub-class.

This error meant that we used the Intel device-specific reset on devices
with class code 0x000c03 instead of those with class code 0x0c03xx.
0x000c03 is a reserved value in the 0x00 backwards compatibility base
class and shouldn't match any devices, so I think reset_intel_generic_dev()
always failed.

I considered adding a shift, but I can't test it, so it's as likely to
break something as to fix something.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
CC: Yu Zhao <yu.zhao@intel.com>
CC: Mathias Nyman <mathias.nyman@intel.com>
drivers/pci/quirks.c