]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
drm/rockchip: don't wait for vblank if fb hasn't changed
authorJohn Keeping <john@metanate.com>
Tue, 19 Jan 2016 10:46:59 +0000 (10:46 +0000)
committerMark Yao <mark.yao@rock-chips.com>
Wed, 20 Jan 2016 00:55:56 +0000 (08:55 +0800)
commitf2227f469782e55765deacb8ebcc7ec05fe04013
tree564366be1561cbfb490d4780cadb8e600acb803e
parentc240906d36653944d5c049df7ce667a7e8bea6ac
drm/rockchip: don't wait for vblank if fb hasn't changed

As commented in drm_atomic_helper_wait_for_vblanks(), userspace relies
on cursor ioctls being unsynced.  Converting the rockchip driver to
atomic has significantly impacted cursor performance by making every
cursor update wait for vblank.

By skipping the vblank sync when the framebuffer has not changed (as is
done in drm_atomic_helper_wait_for_vblanks()) we can avoid this for the
common case of moving the cursor and only need to delay the cursor ioctl
when the cursor icon changes.

We cannot add the check on legacy_cursor_update since that results in
the cursor bo being unreferenced while the hardware may still be reading
it.  Fully supporting unsynced cursor updates is left for the future
when the atomic helper framework supports async updates.

Signed-off-by: John Keeping <john@metanate.com>
Tested-by: Heiko Stuebner <heiko@sntech.de>
drivers/gpu/drm/rockchip/rockchip_drm_fb.c