]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
efi/esrt: Fix some compiler warnings
authorPeter Jones <pjones@redhat.com>
Thu, 30 Apr 2015 14:49:20 +0000 (10:49 -0400)
committerMatt Fleming <matt.fleming@intel.com>
Thu, 30 Apr 2015 21:15:06 +0000 (22:15 +0100)
commitf2f6b587c5533c43f3c26f1babd96e32b2c12a9b
treee8ae9f7d85bb137c65899313dc0d31319fb5c8f7
parenta93e178838b85409601c9b909af5addbbfd90264
efi/esrt: Fix some compiler warnings

Apparently I missed some compiler warnings on 32-bit platforms, where
phys_addr_t isn't the same size as void * and I casted it to make printk
work.  Obviously I should have thought "I'm printing some random type,
instead of typecasting I should check Documentation/printk-formats.txt
and see how to do it." o/~ The More You Know ☆彡 o/~

This patch also fixes one other warning about an uninitialized variable
some compiler versions seem to see.  You can't actually hit the code
path where it would be uninitialized, because there's a prior test that
would error out, but gcc hasn't figured that out.  Anyway, it now has a
test and returns the error at both places.

Signed-off-by: Peter Jones <pjones@redhat.com>
Signed-off-by: Matt Fleming <matt.fleming@intel.com>
drivers/firmware/efi/esrt.c