]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
irqchip: bcm7120-l2: Eliminate bad IRQ check
authorKevin Cernekee <cernekee@gmail.com>
Fri, 7 Nov 2014 06:44:21 +0000 (22:44 -0800)
committerJason Cooper <jason@lakedaemon.net>
Sun, 9 Nov 2014 04:02:29 +0000 (04:02 +0000)
commitf668f074ff58dea540d83bbed1b2c1171b0dd764
treed82f27486376119f66b99fa18c9321967bbbdd2a
parent05f1275745f11c48760c8b6a58751d5bd1a8c0d8
irqchip: bcm7120-l2: Eliminate bad IRQ check

This check may be prone to race conditions, e.g.

1) Some external event (e.g. GPIO level) causes an IRQ to become pending
2) Peripheral asserts the L2 IRQ
3) CPU takes an interrupt
4) The event from #1 goes away
5) bcm7120_l2_intc_irq_handle() reads back a 0 status

Unlike the hardware supported by brcmstb-l2, the bcm7120-l2 controller
does not latch the IRQ status.  Bits can change if the inputs to the
controller change.  Also, do_bad_IRQ() is an ARM-specific macro.

So let's just nuke it.

Signed-off-by: Kevin Cernekee <cernekee@gmail.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lkml.kernel.org/r/1415342669-30640-7-git-send-email-cernekee@gmail.com
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
drivers/irqchip/irq-bcm7120-l2.c