]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
[PATCH] SCSI_SATA has to be a tristate
authorAdrian Bunk <bunk@stusta.de>
Wed, 27 Jul 2005 08:06:35 +0000 (01:06 -0700)
committerJeff Garzik <jgarzik@pobox.com>
Sun, 31 Jul 2005 04:43:00 +0000 (00:43 -0400)
commitfaa725332f39329288f52b7f872ffda866ba5b09
treeab0459721ec3e864eecc4e77e11fc6fe4c2f2d3c
parentb0825488a642cadcf39709961dde61440cb0731c
[PATCH] SCSI_SATA has to be a tristate

SCSI=m must disallow static drivers.

The problem is that all the SATA drivers depend on SCSI_SATA.

With SCSI=m and SCSI_SATA=y this allows the static enabling of the SATA
drivers with unwanted effects, e.g.:
- SCSI=m, SCSI_SATA=y, SCSI_ATA_ADMA=y
  -> SCSI_ATA_ADMA is built statically but scsi/built-in.o is not linked
     into the kernel
- SCSI=m, SCSI_SATA=y, SCSI_ATA_ADMA=y, SCSI_SATA_AHCI=m
  -> SCSI_ATA_ADMA and libata are built statically but
     scsi/built-in.o is not linked into the kernel,
     SCSI_SATA_AHCI is built modular (unresolved symbols due to missing
                                      libata)

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Cc: Jeff Garzik <jgarzik@pobox.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
drivers/scsi/Kconfig