It treats the idle_max_cpu little bit confusingly IMHO. Let's make it
more straight forward.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: David Ahern <dsahern@gmail.com>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Minchan Kim <minchan@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20161206034010.6499-6-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
if (!idle_threads)
return -ENOMEM;
if (!idle_threads)
return -ENOMEM;
- idle_max_cpu = ncpu - 1;
/* allocate the actual thread struct if needed */
for (i = 0; i < ncpu; ++i) {
/* allocate the actual thread struct if needed */
for (i = 0; i < ncpu; ++i) {
if (idle_threads == NULL)
return;
if (idle_threads == NULL)
return;
- for (i = 0; i <= idle_max_cpu; ++i) {
+ for (i = 0; i < idle_max_cpu; ++i) {
if ((idle_threads[i]))
thread__delete(idle_threads[i]);
}
if ((idle_threads[i]))
thread__delete(idle_threads[i]);
}
return NULL;
idle_threads = (struct thread **) p;
return NULL;
idle_threads = (struct thread **) p;
- i = idle_max_cpu ? idle_max_cpu + 1 : 0;
- for (; i < j; ++i)
+ for (i = idle_max_cpu; i < j; ++i)
idle_threads[i] = NULL;
idle_max_cpu = j;
idle_threads[i] = NULL;
idle_max_cpu = j;
return;
printf("\nIdle stats:\n");
return;
printf("\nIdle stats:\n");
- for (i = 0; i <= idle_max_cpu; ++i) {
+ for (i = 0; i < idle_max_cpu; ++i) {
t = idle_threads[i];
if (!t)
continue;
t = idle_threads[i];
if (!t)
continue;