]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
usb: ohci-exynos: Remove locks for 'ohci' in suspend callback
authorVivek Gautam <gautam.vivek@samsung.com>
Tue, 8 Apr 2014 14:40:35 +0000 (20:10 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 24 Apr 2014 20:05:32 +0000 (13:05 -0700)
Patch : 14982e3 USB: OHCI: Properly handle ohci-exynos suspend
has already removed 'ohci_hcd' settings from exynos glue layer
as a part of streamlining the ohci controller's suspend.
So we don't need the locks for 'ohci_hcd' anymore.

Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
Cc: Manjunath Goudar <csmanjuvijay@gmail.com>
Cc: Alan Stern <stern@rowland.harvard.edu>
Acked-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/ohci-exynos.c

index 68588d8a09bb60834d9e2740b488650d7fb42550..9cf80cb7c05107cdbc27601dc0451658702c290f 100644 (file)
@@ -190,17 +190,13 @@ static int exynos_ohci_suspend(struct device *dev)
 {
        struct usb_hcd *hcd = dev_get_drvdata(dev);
        struct exynos_ohci_hcd *exynos_ohci = to_exynos_ohci(hcd);
-       struct ohci_hcd *ohci = hcd_to_ohci(hcd);
        struct platform_device *pdev = to_platform_device(dev);
        bool do_wakeup = device_may_wakeup(dev);
-       unsigned long flags;
        int rc = ohci_suspend(hcd, do_wakeup);
 
        if (rc)
                return rc;
 
-       spin_lock_irqsave(&ohci->lock, flags);
-
        if (exynos_ohci->otg)
                exynos_ohci->otg->set_host(exynos_ohci->otg, &hcd->self);
 
@@ -208,8 +204,6 @@ static int exynos_ohci_suspend(struct device *dev)
 
        clk_disable_unprepare(exynos_ohci->clk);
 
-       spin_unlock_irqrestore(&ohci->lock, flags);
-
        return 0;
 }