]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
nfsd4: typo logical vs bitwise negate
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 17 Oct 2011 07:41:17 +0000 (10:41 +0300)
committerJ. Bruce Fields <bfields@redhat.com>
Mon, 17 Oct 2011 12:35:09 +0000 (08:35 -0400)
This should be a bitwise negate here.  It silences a Sparse warning:
fs/nfsd/nfs4xdr.c:693:16: warning: dubious: x & !y

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
fs/nfsd/nfs4xdr.c

index 2cab33cc3238159dbf55a282f273990fa2766974..645a0a9d80733f1f44a7e9d58e163ea7b244809e 100644 (file)
@@ -690,7 +690,7 @@ static __be32 nfsd4_decode_share_deny(struct nfsd4_compoundargs *argp, u32 *x)
        READ_BUF(4);
        READ32(*x);
        /* Note: unlinke access bits, deny bits may be zero. */
-       if (*x & !NFS4_SHARE_DENY_BOTH)
+       if (*x & ~NFS4_SHARE_DENY_BOTH)
                return nfserr_bad_xdr;
        return nfs_ok;
 xdr_error: