]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
serial: imx: remove null check of sport in suspend/resume function
authorRichard Zhao <richard.zhao@freescale.com>
Tue, 18 Sep 2012 08:14:59 +0000 (16:14 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 21 Sep 2012 16:53:16 +0000 (09:53 -0700)
platform_get_drvdata always retrun a valid value after probe succeed.

It also fixed smatch warnings:
drivers/tty/serial/imx.c:1376 serial_imx_suspend() warn: variable dereferenced before check 'sport' (see line 1372)
drivers/tty/serial/imx.c:1392 serial_imx_resume() warn: variable dereferenced before check 'sport' (see line 1388)

Signed-off-by: Richard Zhao <richard.zhao@freescale.com>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/imx.c

index 49f664f72870bbc0f0b27b188dce209b9e2dd21a..efeb8becfa438c9fd3aa6f52223dbe2670819ad5 100644 (file)
@@ -1373,8 +1373,7 @@ static int serial_imx_suspend(struct platform_device *dev, pm_message_t state)
        val |= UCR3_AWAKEN;
        writel(val, sport->port.membase + UCR3);
 
-       if (sport)
-               uart_suspend_port(&imx_reg, &sport->port);
+       uart_suspend_port(&imx_reg, &sport->port);
 
        return 0;
 }
@@ -1389,8 +1388,7 @@ static int serial_imx_resume(struct platform_device *dev)
        val &= ~UCR3_AWAKEN;
        writel(val, sport->port.membase + UCR3);
 
-       if (sport)
-               uart_resume_port(&imx_reg, &sport->port);
+       uart_resume_port(&imx_reg, &sport->port);
 
        return 0;
 }