]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
net/mlx5e: fix build error without CONFIG_SYSFS
authorTobias Regnery <tobias.regnery@gmail.com>
Wed, 5 Apr 2017 09:11:10 +0000 (11:11 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 6 Apr 2017 19:55:36 +0000 (12:55 -0700)
Commit 9008ae074885 ("net/mlx5e: Minimize mlx5e_{open/close}_locked")
copied the calls to netif_set_real_num_{tx,rx}_queues from
mlx5e_open_locked to mlx5e_activate_priv_channels and wraps them in an
if condition to test for netdev->real_num_{tx,rx}_queues.

But netdev->real_num_rx_queues is conditionally compiled in if CONFIG_SYSFS
is set. Without CONFIG_SYSFS the build fails:

drivers/net/ethernet/mellanox/mlx5/core/en_main.c: In function 'mlx5e_activate_priv_channels':
drivers/net/ethernet/mellanox/mlx5/core/en_main.c:2515:12: error: 'struct net_device' has no member named 'real_num_rx_queues'; did you mean 'real_num_tx_queues'?

Fix this by unconditionally call netif_set_real_num{tx,rx}_queues like before
commit 9008ae074885.

Fixes: 9008ae074885 ("net/mlx5e: Minimize mlx5e_{open/close}_locked")
Signed-off-by: Tobias Regnery <tobias.regnery@gmail.com>
Acked-by: Saeed Mahameed <saeedm@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlx5/core/en_main.c

index ec389b1b51cbdf6f50b0ef299aac588b52fc7e72..d5248637d44fdd38373341a9db82f810da7d2181 100644 (file)
@@ -2510,10 +2510,8 @@ static void mlx5e_activate_priv_channels(struct mlx5e_priv *priv)
        struct net_device *netdev = priv->netdev;
 
        mlx5e_netdev_set_tcs(netdev);
-       if (netdev->real_num_tx_queues != num_txqs)
-               netif_set_real_num_tx_queues(netdev, num_txqs);
-       if (netdev->real_num_rx_queues != priv->channels.num)
-               netif_set_real_num_rx_queues(netdev, priv->channels.num);
+       netif_set_real_num_tx_queues(netdev, num_txqs);
+       netif_set_real_num_rx_queues(netdev, priv->channels.num);
 
        mlx5e_build_channels_tx_maps(priv);
        mlx5e_activate_channels(&priv->channels);