]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
V4L/DVB: Missing statement in drivers/media/dvb/frontends/cx22700.c
authorEric Sesterhenn <snakebyte@gmx.de>
Wed, 24 Jan 2007 23:05:10 +0000 (00:05 +0100)
committerAdrian Bunk <bunk@stusta.de>
Wed, 24 Jan 2007 23:05:10 +0000 (00:05 +0100)
Stumbled over this because of coverity (id #492),
seems like we are missing a return statement here and fail
to do proper bounds checking. If this assumption is false
we should at least change the identation to make it clear

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Adrian Bunk <bunk@stusta.de>
drivers/media/dvb/frontends/cx22700.c

index 755f774f6b7d4262077def4b7a22b4f5b09efec1..dfa8d9787f832a5ce5ee3c5c5973f28f53c04306 100644 (file)
@@ -136,6 +136,7 @@ static int cx22700_set_tps (struct cx22700_state *state, struct dvb_ofdm_paramet
                return -EINVAL;
 
        if (p->code_rate_LP < FEC_1_2 || p->code_rate_LP > FEC_7_8)
+               return -EINVAL;
 
        if (p->code_rate_HP == FEC_4_5 || p->code_rate_LP == FEC_4_5)
                return -EINVAL;