]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
[media] em28xx: Fix height setting on non-progressive captures
authorMauro Carvalho Chehab <mchehab@redhat.com>
Fri, 3 Aug 2012 16:52:32 +0000 (13:52 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Sun, 12 Aug 2012 10:09:06 +0000 (07:09 -0300)
This was introduced on commit c2a6b54a9:
"em28xx: fix: don't do image interlacing on webcams"

The proposed patch by Ezequiel is wrong. The right fix here is to just
don't bother here if either the image is progressive or not.

Reported-by: Ezequiel Garcia <elezegarcia@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/video/em28xx/em28xx-core.c

index de2cb20ad2cc1d676c6aa0c532e36bc251c4273e..bed07a6c33f8156df80919725c05857cd0fd9b37 100644 (file)
@@ -785,12 +785,8 @@ int em28xx_resolution_set(struct em28xx *dev)
        else
                dev->vbi_height = 18;
 
-       if (!dev->progressive)
-               height >>= norm_maxh(dev);
-
        em28xx_set_outfmt(dev);
 
-
        em28xx_accumulator_set(dev, 1, (width - 4) >> 2, 1, (height - 4) >> 2);
 
        /* If we don't set the start position to 2 in VBI mode, we end up