]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
Revert "net: fix rds_iovec page count overflow"
authorGreg Kroah-Hartman <gregkh@suse.de>
Fri, 15 Apr 2011 20:52:37 +0000 (13:52 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 15 Apr 2011 20:52:37 +0000 (13:52 -0700)
This reverts commit b291661643c93044e6d4a228d3268649ccf30a0c (originally
commit 1b1f693d7ad6d193862dcb1118540a030c5e761f upstream).

I messed it up in backporting it to the .33-stable kernel, so revert it
for now and try it again the next review cycle.

Cc: Thomas Pollet <thomas.pollet@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andy Grover <andy.grover@oracle.com>
Cc: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
net/rds/rdma.c

index 4810a25a53c7264b028991ef8b026b840ae75c8a..1fa0f4b9fac3e306d6d5751d58d4c7fda360f72b 100644 (file)
@@ -497,14 +497,6 @@ static struct rds_rdma_op *rds_rdma_prepare(struct rds_sock *rs,
 
                max_pages = max(nr, max_pages);
                nr_pages += nr;
-
-               /*
-                * nr_pages for one entry is limited to (UINT_MAX>>PAGE_SHIFT)+1,
-                * so tot_pages cannot overflow without first going negative.
-                */
-               if ((int)nr_pages < 0)
-                       ret = -EINVAL;
-                       goto out;
        }
 
        pages = kcalloc(max_pages, sizeof(struct page *), GFP_KERNEL);