]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
USB: ehci-platform: Display a DMA configuration error message
authorJeremy Linton <jeremy.linton@arm.com>
Wed, 19 Aug 2015 21:36:31 +0000 (16:36 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 4 Oct 2015 09:47:13 +0000 (10:47 +0100)
If the ehci driver fails to configure the dma settings then display
a dev error instead of simply failing. This is triggered in an
ACPI world if the user fails to set the _CCA on the device.

Tested-by: Huang Shijie <shijie.huang@arm.com>
Reviewed-by: Graeme Gregory <graeme.gregory@linaro.org>
Reviewed-by: Hanjun Guo <hanjun.guo@linaro.org>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/ehci-platform.c

index 5c3c0859868251233c7672baf9f2ea01c5b82364..d9144d5ab794febf06d0a293eb72c2102a615890 100644 (file)
@@ -162,8 +162,10 @@ static int ehci_platform_probe(struct platform_device *dev)
 
        err = dma_coerce_mask_and_coherent(&dev->dev,
                pdata->dma_mask_64 ? DMA_BIT_MASK(64) : DMA_BIT_MASK(32));
-       if (err)
+       if (err) {
+               dev_err(&dev->dev, "Error: DMA mask configuration failed\n");
                return err;
+       }
 
        irq = platform_get_irq(dev, 0);
        if (irq < 0) {