]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
drm/i2c: tda998x: fix npix/nline programming
authorRussell King <rmk+kernel@arm.linux.org.uk>
Wed, 14 Aug 2013 19:43:28 +0000 (21:43 +0200)
committerDave Airlie <airlied@redhat.com>
Sun, 18 Aug 2013 23:10:13 +0000 (09:10 +1000)
The npix/nline registers are supposed to be programmed with the total
number of pixels/lines, not the displayed pixels/lines, and not minus
one either.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Tested-by: Darren Etheridge <detheridge@ti.com>
Tested-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Tested-by: Russell King <rmk_kernel@arm.linux.org.uk>
Signed-off-by: Dave Airlie <airlied@redhat.com>
drivers/gpu/drm/i2c/tda998x_drv.c

index cb9b13ad1ae6c75553184e863555784917ff0905..a701411fcc0d45229dee3cf930ae148202eb0d15 100644 (file)
@@ -587,8 +587,8 @@ tda998x_encoder_mode_set(struct drm_encoder *encoder,
                reg_set(encoder, REG_VIP_CNTRL_3, VIP_CNTRL_3_H_TGL);
 
        reg_write(encoder, REG_VIDFORMAT, 0x00);
-       reg_write16(encoder, REG_NPIX_MSB, mode->hdisplay - 1);
-       reg_write16(encoder, REG_NLINE_MSB, mode->vdisplay - 1);
+       reg_write16(encoder, REG_NPIX_MSB, mode->htotal);
+       reg_write16(encoder, REG_NLINE_MSB, mode->vtotal);
        reg_write16(encoder, REG_VS_LINE_STRT_1_MSB, line_start);
        reg_write16(encoder, REG_VS_LINE_END_1_MSB, line_end);
        reg_write16(encoder, REG_VS_PIX_STRT_1_MSB, hs_start);