]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
ata: Delete unnecessary checks before the function call "pci_dev_put"
authorMarkus Elfring <elfring@users.sourceforge.net>
Mon, 2 Feb 2015 21:08:29 +0000 (22:08 +0100)
committerTejun Heo <tj@kernel.org>
Tue, 3 Feb 2015 12:04:44 +0000 (07:04 -0500)
The pci_dev_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Tejun Heo <tj@kernel.org>
drivers/ata/pata_cs5530.c

index 48ae4b43447450e221a8f016418f087df0f2d421..f9ca72e937ee177feb0f54d10afabd51fbd74183 100644 (file)
@@ -276,10 +276,8 @@ static int cs5530_init_chip(void)
        pci_dev_put(cs5530_0);
        return 0;
 fail_put:
-       if (master_0)
-               pci_dev_put(master_0);
-       if (cs5530_0)
-               pci_dev_put(cs5530_0);
+       pci_dev_put(master_0);
+       pci_dev_put(cs5530_0);
        return -ENODEV;
 }