]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
net: rate-limit warn-bad-offload splats.
authorBen Greear <greearb@candelatech.com>
Fri, 19 Apr 2013 10:45:52 +0000 (10:45 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 1 May 2013 16:46:20 +0000 (09:46 -0700)
[ Upstream commit c846ad9b880ece01bb4d8d07ba917734edf0324f ]

If one does do something unfortunate and allow a
bad offload bug into the kernel, this the
skb_warn_bad_offload can effectively live-lock the
system, filling the logs with the same error over
and over.

Add rate limitation to this so that box remains otherwise
functional in this case.

Signed-off-by: Ben Greear <greearb@candelatech.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/core/dev.c

index 28b6f97c340dea405bbbedad0830523552d6f47a..d592214b1393bec9031c572cb29cb7c17bc86ca4 100644 (file)
@@ -2018,6 +2018,9 @@ static void skb_warn_bad_offload(const struct sk_buff *skb)
        struct net_device *dev = skb->dev;
        const char *driver = "";
 
+       if (!net_ratelimit())
+               return;
+
        if (dev && dev->dev.parent)
                driver = dev_driver_string(dev->dev.parent);