]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
nfp: flush xmit_more on error paths
authorJakub Kicinski <jakub.kicinski@netronome.com>
Wed, 22 Mar 2017 00:59:19 +0000 (17:59 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 22 Mar 2017 19:59:09 +0000 (12:59 -0700)
In case of ring full or DMA mapping error remember to flush xmit_more
delayed kicks.

Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/netronome/nfp/nfp_net_common.c

index 255294b8bc5f77f043a76cede0341bbdc6706584..d35eeba86bacc92811aa8a2533af9c538d0c1252 100644 (file)
@@ -759,6 +759,7 @@ static int nfp_net_tx(struct sk_buff *skb, struct net_device *netdev)
                nn_dp_warn(dp, "TX ring %d busy. wrp=%u rdp=%u\n",
                           qidx, tx_ring->wr_p, tx_ring->rd_p);
                netif_tx_stop_queue(nd_q);
+               nfp_net_tx_xmit_more_flush(tx_ring);
                u64_stats_update_begin(&r_vec->tx_sync);
                r_vec->tx_busy++;
                u64_stats_update_end(&r_vec->tx_sync);
@@ -867,6 +868,7 @@ err_unmap:
        tx_ring->txbufs[wr_idx].fidx = -2;
 err_free:
        nn_dp_warn(dp, "Failed to map DMA TX buffer\n");
+       nfp_net_tx_xmit_more_flush(tx_ring);
        u64_stats_update_begin(&r_vec->tx_sync);
        r_vec->tx_errors++;
        u64_stats_update_end(&r_vec->tx_sync);