]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
usb: gadget: f_ecm: fix missing unlock on error in ecm_alloc()
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>
Tue, 18 Jun 2013 04:21:21 +0000 (12:21 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 18 Jun 2013 17:50:07 +0000 (10:50 -0700)
Add the missing unlock before return from function ecm_alloc()
in the error handling case.

Introduced by commit da92801c647cdebfd45001fd6aaecb8f0be7f56b.
(usb: gadget: f_ecm: add configfs support)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/gadget/f_ecm.c

index fcafe1af45850f5ee3d9906efb91d4beefcccefd..5d3561ea1c1595ea30f07bc3ad35253647701d97 100644 (file)
@@ -1012,6 +1012,7 @@ struct usb_function *ecm_alloc(struct usb_function_instance *fi)
                                          sizeof(ecm->ethaddr));
        if (status < 12) {
                kfree(ecm);
+               mutex_unlock(&opts->lock);
                return ERR_PTR(-EINVAL);
        }
        ecm_string_defs[1].s = ecm->ethaddr;