]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
myri10ge: Delete an unnecessary check before the function call "kfree"
authorMarkus Elfring <elfring@users.sourceforge.net>
Wed, 4 Feb 2015 11:32:14 +0000 (12:32 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 5 Feb 2015 08:25:10 +0000 (00:25 -0800)
The kfree() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/myricom/myri10ge/myri10ge.c

index 71af98bb72cbeb1cc2376013847835c4195ec805..1412f5af05ecf521e41ff109dc1a24e7621090ce 100644 (file)
@@ -4226,8 +4226,7 @@ static void myri10ge_remove(struct pci_dev *pdev)
                mtrr_del(mgp->mtrr, mgp->iomem_base, mgp->board_span);
 #endif
        myri10ge_free_slices(mgp);
-       if (mgp->msix_vectors != NULL)
-               kfree(mgp->msix_vectors);
+       kfree(mgp->msix_vectors);
        dma_free_coherent(&pdev->dev, sizeof(*mgp->cmd),
                          mgp->cmd, mgp->cmd_bus);