]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
nfp: remove unnecessary parameters from nfp_net_bpf_offload()
authorJakub Kicinski <jakub.kicinski@netronome.com>
Thu, 3 Nov 2016 17:12:08 +0000 (17:12 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 4 Nov 2016 18:56:16 +0000 (14:56 -0400)
nfp_net_bpf_offload() takes all .setup_tc() parameters but it
doesn't use them at the moment.  Remove unnecessary ones to make
it possible for XDP to reuse this function.

Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/netronome/nfp/nfp_net.h
drivers/net/ethernet/netronome/nfp/nfp_net_common.c
drivers/net/ethernet/netronome/nfp/nfp_net_offload.c

index abc9e56e93b85f2ef2b5ba820a191c4a94ebfc38..fd29a6306991d054eb2fc1fd1e938f7cdb740a50 100644 (file)
@@ -817,8 +817,6 @@ static inline void nfp_net_debugfs_adapter_del(struct nfp_net *nn)
 #endif /* CONFIG_NFP_NET_DEBUG */
 
 void nfp_net_filter_stats_timer(unsigned long data);
-int
-nfp_net_bpf_offload(struct nfp_net *nn, u32 handle, __be16 proto,
-                   struct tc_cls_bpf_offload *cls_bpf);
+int nfp_net_bpf_offload(struct nfp_net *nn, struct tc_cls_bpf_offload *cls_bpf);
 
 #endif /* _NFP_NET_H_ */
index fa43dbcecc4f70c2254ce3838853991216cad076..1e8e00d25c51b4c665159beeed7343107210bbff 100644 (file)
@@ -2694,7 +2694,7 @@ nfp_net_setup_tc(struct net_device *netdev, u32 handle, __be16 proto,
                return -ENOTSUPP;
 
        if (tc->type == TC_SETUP_CLSBPF && nfp_net_ebpf_capable(nn))
-               return nfp_net_bpf_offload(nn, handle, proto, tc->cls_bpf);
+               return nfp_net_bpf_offload(nn, tc->cls_bpf);
 
        return -EINVAL;
 }
index cfed40c0e310aaacb524202141a808db944caa48..4bb6f16e2a7ac8670feb26b3fce233889b4ad813 100644 (file)
@@ -233,9 +233,7 @@ static int nfp_net_bpf_stop(struct nfp_net *nn)
        return nfp_net_reconfig(nn, NFP_NET_CFG_UPDATE_GEN);
 }
 
-int
-nfp_net_bpf_offload(struct nfp_net *nn, u32 handle, __be16 proto,
-                   struct tc_cls_bpf_offload *cls_bpf)
+int nfp_net_bpf_offload(struct nfp_net *nn, struct tc_cls_bpf_offload *cls_bpf)
 {
        struct nfp_bpf_result res;
        dma_addr_t dma_addr;