]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
dm: use bioset_create_nobvec()
authorJunichi Nomura <j-nomura@ce.jp.nec.com>
Fri, 3 Oct 2014 11:55:26 +0000 (11:55 +0000)
committerMike Snitzer <snitzer@redhat.com>
Mon, 6 Oct 2014 00:03:34 +0000 (20:03 -0400)
Since DM core uses bio_clone_fast() for both bio-based and request-based
DM devices there is no need for DM's bioset to have a bvec mempool.

With this patch, on arch with 4KB page for example, memory usage will be
reduced by 64KB for each bio-based DM device and 1MB for each
request-based DM device.

For example, when you create 10,000 bio-based DM devices and 1,000
request-based DM devices, memory usage of biovec under no load is:
  # grep biovec /proc/slabinfo

  biovec-256        418068 418068   4096  ...
  biovec-128             0      0   2048  ...
  biovec-64              0      0   1024  ...
  biovec-16              0      0    256  ...

With this patch series applied, the usage becomes:
  # grep biovec /proc/slabinfo

  biovec-256           116    116   4096  ...
  biovec-128             0      0   2048  ...
  biovec-64              0      0   1024  ...
  biovec-16              0      0    256  ...

So 4096 * (418068 - 116) = 1.6GB of memory is saved in this example.

Signed-off-by: Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
drivers/md/dm.c

index 0b9de07d585b730c556696950457720b424df47e..56a2c74c9a3f5fb8f0a1427b03c5710edb893aec 100644 (file)
@@ -2895,7 +2895,7 @@ struct dm_md_mempools *dm_alloc_md_mempools(unsigned type, unsigned integrity, u
        if (!pools->io_pool)
                goto out;
 
-       pools->bs = bioset_create(pool_size, front_pad);
+       pools->bs = bioset_create_nobvec(pool_size, front_pad);
        if (!pools->bs)
                goto out;