]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
usb: dwc3: define DWC3_EP0_BOUNCE_SIZE
authorFelipe Balbi <balbi@ti.com>
Fri, 4 May 2012 09:58:14 +0000 (12:58 +0300)
committerFelipe Balbi <balbi@ti.com>
Fri, 4 May 2012 09:58:14 +0000 (12:58 +0300)
to avoid sprinkling magic constants on the driver
we define a constant to be used when allocating
setup_buffer and ep0_bounce buffer.

Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/dwc3/core.h
drivers/usb/dwc3/gadget.c

index ef28bd5680c551645ef573ee232606f6e1c4166c..fbd0c8e30c1913d2762b7b8603453383bed7302e 100644 (file)
@@ -51,6 +51,7 @@
 #include <linux/usb/gadget.h>
 
 /* Global constants */
+#define DWC3_EP0_BOUNCE_SIZE   512
 #define DWC3_ENDPOINTS_NUM     32
 #define DWC3_XHCI_RESOURCES_NUM        2
 
index 31ffc5c273543a6c35068837c212347d83207ffc..12844393bc3e26cf28dc698d65c31cbbd4a1a83c 100644 (file)
@@ -2319,7 +2319,7 @@ int __devinit dwc3_gadget_init(struct dwc3 *dwc)
                goto err1;
        }
 
-       dwc->setup_buf = kzalloc(512, GFP_KERNEL);
+       dwc->setup_buf = kzalloc(DWC3_EP0_BOUNCE_SIZE, GFP_KERNEL);
        if (!dwc->setup_buf) {
                dev_err(dwc->dev, "failed to allocate setup buffer\n");
                ret = -ENOMEM;
@@ -2327,7 +2327,8 @@ int __devinit dwc3_gadget_init(struct dwc3 *dwc)
        }
 
        dwc->ep0_bounce = dma_alloc_coherent(dwc->dev,
-                       512, &dwc->ep0_bounce_addr, GFP_KERNEL);
+                       DWC3_EP0_BOUNCE_SIZE, &dwc->ep0_bounce_addr,
+                       GFP_KERNEL);
        if (!dwc->ep0_bounce) {
                dev_err(dwc->dev, "failed to allocate ep0 bounce buffer\n");
                ret = -ENOMEM;
@@ -2414,8 +2415,8 @@ err5:
        dwc3_gadget_free_endpoints(dwc);
 
 err4:
-       dma_free_coherent(dwc->dev, 512, dwc->ep0_bounce,
-                       dwc->ep0_bounce_addr);
+       dma_free_coherent(dwc->dev, DWC3_EP0_BOUNCE_SIZE,
+                       dwc->ep0_bounce, dwc->ep0_bounce_addr);
 
 err3:
        kfree(dwc->setup_buf);
@@ -2444,8 +2445,8 @@ void dwc3_gadget_exit(struct dwc3 *dwc)
 
        dwc3_gadget_free_endpoints(dwc);
 
-       dma_free_coherent(dwc->dev, 512, dwc->ep0_bounce,
-                       dwc->ep0_bounce_addr);
+       dma_free_coherent(dwc->dev, DWC3_EP0_BOUNCE_SIZE,
+                       dwc->ep0_bounce, dwc->ep0_bounce_addr);
 
        kfree(dwc->setup_buf);