]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
amdkfd: Fix sparse warnings in kfd_chardev.c
authorOded Gabbay <oded.gabbay@amd.com>
Thu, 20 Nov 2014 13:37:13 +0000 (15:37 +0200)
committerOded Gabbay <oded.gabbay@amd.com>
Thu, 20 Nov 2014 13:37:13 +0000 (15:37 +0200)
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Oded Gabbay <oded.gabbay@amd.com>
drivers/gpu/drm/amd/amdkfd/kfd_chardev.c

index 64c73bae960d7445589c08fbef16411f0cd2f230..3b3fce7331368efe8a2cf461f074d8404c31bdfb 100644 (file)
@@ -149,7 +149,9 @@ static int set_queue_properties_from_user(struct queue_properties *q_properties,
        }
 
        if ((args->ring_base_address) &&
-               (!access_ok(VERIFY_WRITE, args->ring_base_address, sizeof(uint64_t)))) {
+               (!access_ok(VERIFY_WRITE,
+                       (const void __user *) args->ring_base_address,
+                       sizeof(uint64_t)))) {
                pr_err("kfd: can't access ring base address\n");
                return -EFAULT;
        }
@@ -159,12 +161,16 @@ static int set_queue_properties_from_user(struct queue_properties *q_properties,
                return -EINVAL;
        }
 
-       if (!access_ok(VERIFY_WRITE, args->read_pointer_address, sizeof(uint32_t))) {
+       if (!access_ok(VERIFY_WRITE,
+                       (const void __user *) args->read_pointer_address,
+                       sizeof(uint32_t))) {
                pr_err("kfd: can't access read pointer\n");
                return -EFAULT;
        }
 
-       if (!access_ok(VERIFY_WRITE, args->write_pointer_address, sizeof(uint32_t))) {
+       if (!access_ok(VERIFY_WRITE,
+                       (const void __user *) args->write_pointer_address,
+                       sizeof(uint32_t))) {
                pr_err("kfd: can't access write pointer\n");
                return -EFAULT;
        }
@@ -325,7 +331,9 @@ static int kfd_ioctl_update_queue(struct file *filp, struct kfd_process *p,
        }
 
        if ((args.ring_base_address) &&
-               (!access_ok(VERIFY_WRITE, args.ring_base_address, sizeof(uint64_t)))) {
+               (!access_ok(VERIFY_WRITE,
+                       (const void __user *) args.ring_base_address,
+                       sizeof(uint64_t)))) {
                pr_err("kfd: can't access ring base address\n");
                return -EFAULT;
        }