]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
mlx4: use reset to set mac header
authorZhang Shengju <zhangshengju@cmss.chinamobile.com>
Fri, 2 Dec 2016 01:51:05 +0000 (09:51 +0800)
committerDavid S. Miller <davem@davemloft.net>
Sat, 3 Dec 2016 20:49:16 +0000 (15:49 -0500)
Since offset is zero, it's not necessary to use set function. Reset
function is straightforward, and will remove the unnecessary add
operation in set function.

Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlx4/en_selftest.c

index c06346a82496876379ff5771e9ae7a03b4ad10a0..95290e1fc9fe7600b2e3bcca334f3fad7d733c09 100644 (file)
@@ -68,7 +68,7 @@ static int mlx4_en_test_loopback_xmit(struct mlx4_en_priv *priv)
        memcpy(ethh->h_dest, priv->dev->dev_addr, ETH_ALEN);
        eth_zero_addr(ethh->h_source);
        ethh->h_proto = htons(ETH_P_ARP);
-       skb_set_mac_header(skb, 0);
+       skb_reset_mac_header(skb);
        for (i = 0; i < packet_size; ++i)       /* fill our packet */
                packet[i] = (unsigned char)(i & 0xff);