]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
iser-target: Add missing target_put_sess_cmd for ImmedateData failure
authorNicholas Bellinger <nab@linux-iscsi.org>
Fri, 23 May 2014 07:48:35 +0000 (00:48 -0700)
committerNicholas Bellinger <nab@linux-iscsi.org>
Wed, 4 Jun 2014 02:17:31 +0000 (19:17 -0700)
This patch addresses a bug where an early exception for SCSI WRITE
with ImmediateData=Yes was missing the target_put_sess_cmd() call
to drop the extra se_cmd->cmd_kref reference obtained during the
normal iscsit_setup_scsi_cmd() codepath execution.

This bug was manifesting itself during session shutdown within
isert_cq_rx_comp_err() where target_wait_for_sess_cmds() would
end up waiting indefinately for the last se_cmd->cmd_kref put to
occur for the failed SCSI WRITE + ImmediateData descriptors.

This fix follows what traditional iscsi-target code already does
for the same failure case within iscsit_get_immediate_data().

Reported-by: Sagi Grimberg <sagig@dev.mellanox.co.il>
Cc: Sagi Grimberg <sagig@dev.mellanox.co.il>
Cc: Or Gerlitz <ogerlitz@mellanox.com>
Cc: stable@vger.kernel.org # 3.10+
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/infiniband/ulp/isert/ib_isert.c

index a1710465faaf2345ae9c88755790e3e74a6e76e8..b9d647468b99e66ed44c4a1176744ef5eefdbc82 100644 (file)
@@ -1210,6 +1210,8 @@ sequence_cmd:
 
        if (!rc && dump_payload == false && unsol_data)
                iscsit_set_unsoliticed_dataout(cmd);
+       else if (dump_payload && imm_data)
+               target_put_sess_cmd(conn->sess->se_sess, &cmd->se_cmd);
 
        return 0;
 }