]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
drivers/video/cyber2000fb.c: fix error return code
authorPeter Senna Tschudin <peter.senna@gmail.com>
Tue, 18 Sep 2012 12:07:58 +0000 (14:07 +0200)
committerFlorian Tobias Schandinat <FlorianSchandinat@gmx.de>
Sat, 22 Sep 2012 21:41:52 +0000 (21:41 +0000)
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
drivers/video/cyber2000fb.c

index c1527f5b47eec53af0c54f33ff8e143afcf1c402..e40125cb313e95080e49abdcad344195707c4232 100644 (file)
@@ -1804,8 +1804,10 @@ cyberpro_pci_probe(struct pci_dev *dev, const struct pci_device_id *id)
 
        cfb->irq = dev->irq;
        cfb->region = pci_ioremap_bar(dev, 0);
-       if (!cfb->region)
+       if (!cfb->region) {
+               err = -ENOMEM;
                goto failed_ioremap;
+       }
 
        cfb->regs = cfb->region + MMIO_OFFSET;
        cfb->fb.device = &dev->dev;