]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
scsi: lpfc: use proper format string for dma_addr_t
authorArnd Bergmann <arnd@arndb.de>
Mon, 27 Feb 2017 20:37:12 +0000 (21:37 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 28 Feb 2017 03:08:40 +0000 (22:08 -0500)
dma_addr_t may be either u32 or u64, depending on the kernel configuration,
and we get a warning for the 32-bit case:

drivers/scsi/lpfc/lpfc_nvme.c: In function 'lpfc_nvme_ls_req':
drivers/scsi/lpfc/lpfc_logmsg.h:52:52: error: format '%llu' expects argument of type 'long long unsigned int', but argument 11 has type 'dma_addr_t {aka unsigned int}' [-Werror=format=]
drivers/scsi/lpfc/lpfc_logmsg.h:52:52: error: format '%llu' expects argument of type 'long long unsigned int', but argument 12 has type 'dma_addr_t {aka unsigned int}' [-Werror=format=]
drivers/scsi/lpfc/lpfc_nvme.c: In function 'lpfc_nvme_ls_abort':
drivers/scsi/lpfc/lpfc_logmsg.h:52:52: error: format '%llu' expects argument of type 'long long unsigned int', but argument 11 has type 'dma_addr_t {aka unsigned int}' [-Werror=format=]
drivers/scsi/lpfc/lpfc_logmsg.h:52:52: error: format '%llu' expects argument of type 'long long unsigned int', but argument 12 has type 'dma_addr_t {aka unsigned int}' [-Werror=format=]

printk has a special "%pad" format string that passes the dma address by
reference to solve this problem.

Fixes: 01649561a8b4 ("scsi: lpfc: NVME Initiator: bind to nvme_fc api")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/lpfc/lpfc_nvme.c

index 625b6589a34deb6de9a02406c72e63050ea23c42..609a908ea9db5ba291e678c296726d69cae784f9 100644 (file)
@@ -457,11 +457,11 @@ lpfc_nvme_ls_req(struct nvme_fc_local_port *pnvme_lport,
        /* Expand print to include key fields. */
        lpfc_printf_vlog(vport, KERN_INFO, LOG_NVME_DISC,
                         "6051 ENTER.  lport %p, rport %p lsreq%p rqstlen:%d "
-                        "rsplen:%d %llux %llux\n",
+                        "rsplen:%d %pad %pad\n",
                         pnvme_lport, pnvme_rport,
                         pnvme_lsreq, pnvme_lsreq->rqstlen,
-                        pnvme_lsreq->rsplen, pnvme_lsreq->rqstdma,
-                        pnvme_lsreq->rspdma);
+                        pnvme_lsreq->rsplen, &pnvme_lsreq->rqstdma,
+                        &pnvme_lsreq->rspdma);
 
        vport->phba->fc4NvmeLsRequests++;
 
@@ -527,11 +527,11 @@ lpfc_nvme_ls_abort(struct nvme_fc_local_port *pnvme_lport,
        /* Expand print to include key fields. */
        lpfc_printf_vlog(vport, KERN_INFO, LOG_NVME_ABTS,
                         "6040 ENTER.  lport %p, rport %p lsreq %p rqstlen:%d "
-                        "rsplen:%d %llux %llux\n",
+                        "rsplen:%d %pad %pad\n",
                         pnvme_lport, pnvme_rport,
                         pnvme_lsreq, pnvme_lsreq->rqstlen,
-                        pnvme_lsreq->rsplen, pnvme_lsreq->rqstdma,
-                        pnvme_lsreq->rspdma);
+                        pnvme_lsreq->rsplen, &pnvme_lsreq->rqstdma,
+                        &pnvme_lsreq->rspdma);
 
        /*
         * Lock the ELS ring txcmplq and build a local list of all ELS IOs