]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
x86/mce Add validation check before GHES error is recorded
authorChen Gong <gong.chen@linux.intel.com>
Fri, 20 Apr 2012 23:02:05 +0000 (16:02 -0700)
committerTony Luck <tony.luck@intel.com>
Fri, 20 Apr 2012 23:02:05 +0000 (16:02 -0700)
When GHES error record is logged into mcelog kernel buffer, a validation
check for physical address is necessary, which prevents reporting an
invalid physical address.

[Since physical address is the only useful element in this error record,
we drop generating the record completely if we don't have a valid address]

Signed-off-by: Chen Gong <gong.chen@linux.intel.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>
arch/x86/kernel/cpu/mcheck/mce-apei.c

index 507ea58688e251c12d9f33313cf5493edab3d499..cd8b166a1735326d614d92ef6b44292149c8c5cd 100644 (file)
@@ -42,7 +42,8 @@ void apei_mce_report_mem_error(int corrected, struct cper_sec_mem_err *mem_err)
        struct mce m;
 
        /* Only corrected MC is reported */
-       if (!corrected)
+       if (!corrected || !(mem_err->validation_bits &
+                               CPER_MEM_VALID_PHYSICAL_ADDRESS))
                return;
 
        mce_setup(&m);