]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
drm/i915/dp: actually nack test request
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Sat, 20 Oct 2012 19:13:05 +0000 (21:13 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 23 Oct 2012 14:39:33 +0000 (16:39 +0200)
... like the comment says. No idea whether this has any effect, but
I guess it's better to not lie to the display by acking a test request
and never following through with it. This goes back to the commit that
originally introduced this code:

commit a60f0e38d72a5e24085d6e7e27a4cadc20ae268a
Author: Jesse Barnes <jbarnes@virtuousgeek.org>
Date:   Thu Oct 20 15:09:17 2011 -0700

    drm/i915: add DP test request handling

Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Meh'ed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_dp.c

index e0b91cb75d63af44fa66de9e26822c5b40ffe737..fda207e7a28257bda17f822368b1a82d7679267a 100644 (file)
@@ -2074,7 +2074,7 @@ static void
 intel_dp_handle_test_request(struct intel_dp *intel_dp)
 {
        /* NAK by default */
-       intel_dp_aux_native_write_1(intel_dp, DP_TEST_RESPONSE, DP_TEST_ACK);
+       intel_dp_aux_native_write_1(intel_dp, DP_TEST_RESPONSE, DP_TEST_NAK);
 }
 
 /*