]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
sectons-fix-const-sections-for-crc32-table-checkpatch-fixes
authorAndrew Morton <akpm@linux-foundation.org>
Fri, 28 Sep 2012 00:20:10 +0000 (10:20 +1000)
committerStephen Rothwell <sfr@canb.auug.org.au>
Wed, 3 Oct 2012 06:50:38 +0000 (16:50 +1000)
ERROR: code indent should use tabs where possible
#54: FILE: lib/gen_crc32table.c:112:
+        ^Iprintf("static u32 __cacheline_aligned "$

WARNING: please, no space before tabs
#54: FILE: lib/gen_crc32table.c:112:
+        ^Iprintf("static u32 __cacheline_aligned "$

WARNING: please, no spaces at the start of a line
#54: FILE: lib/gen_crc32table.c:112:
+        ^Iprintf("static u32 __cacheline_aligned "$

ERROR: code indent should use tabs where possible
#63: FILE: lib/gen_crc32table.c:122:
+        ^Iprintf("static u32 __cacheline_aligned "$

WARNING: please, no space before tabs
#63: FILE: lib/gen_crc32table.c:122:
+        ^Iprintf("static u32 __cacheline_aligned "$

WARNING: please, no spaces at the start of a line
#63: FILE: lib/gen_crc32table.c:122:
+        ^Iprintf("static u32 __cacheline_aligned "$

ERROR: code indent should use tabs where possible
#72: FILE: lib/gen_crc32table.c:131:
+        ^Iprintf("static u32 __cacheline_aligned "$

WARNING: please, no space before tabs
#72: FILE: lib/gen_crc32table.c:131:
+        ^Iprintf("static u32 __cacheline_aligned "$

WARNING: please, no spaces at the start of a line
#72: FILE: lib/gen_crc32table.c:131:
+        ^Iprintf("static u32 __cacheline_aligned "$

total: 3 errors, 6 warnings, 48 lines checked

NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
      scripts/cleanfile

./patches/sectons-fix-const-sections-for-crc32-table.patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Andi Kleen <ak@linux.intel.com>
Cc: Joe Mario <jmario@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
lib/gen_crc32table.c

index 75fac57a12ba3dfe70deb71334dc16ed593f48ee..71fcfcd964104f732c0e9c3ac0af45620fd438b7 100644 (file)
@@ -109,7 +109,7 @@ int main(int argc, char** argv)
 
        if (CRC_LE_BITS > 1) {
                crc32init_le();
-               printf("static u32 __cacheline_aligned "
+               printf("static u32 __cacheline_aligned "
                       "crc32table_le[%d][%d] = {",
                       LE_TABLE_ROWS, LE_TABLE_SIZE);
                output_table(crc32table_le, LE_TABLE_ROWS,
@@ -119,7 +119,7 @@ int main(int argc, char** argv)
 
        if (CRC_BE_BITS > 1) {
                crc32init_be();
-               printf("static u32 __cacheline_aligned "
+               printf("static u32 __cacheline_aligned "
                       "crc32table_be[%d][%d] = {",
                       BE_TABLE_ROWS, BE_TABLE_SIZE);
                output_table(crc32table_be, LE_TABLE_ROWS,
@@ -128,7 +128,7 @@ int main(int argc, char** argv)
        }
        if (CRC_LE_BITS > 1) {
                crc32cinit_le();
-               printf("static u32 __cacheline_aligned "
+               printf("static u32 __cacheline_aligned "
                       "crc32ctable_le[%d][%d] = {",
                       LE_TABLE_ROWS, LE_TABLE_SIZE);
                output_table(crc32ctable_le, LE_TABLE_ROWS,