]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
ocfs2: removes mlog_errno() call twice in ocfs2_find_dir_space_el()
authorDaeseok Youn <daeseok.youn@gmail.com>
Tue, 10 Feb 2015 22:09:15 +0000 (14:09 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 10 Feb 2015 22:30:29 +0000 (14:30 -0800)
mlog_errno() is called twice when some functions are failed.

Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Cc: Mark Fasheh <mfasheh@suse.com>
Cc: Joel Becker <jlbec@evilplan.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/ocfs2/dir.c

index 940be6d994a92726cddec8f0e63672a91405d8db..b08050bd3f2ef81a2c2f053042ac7e9e763e3718 100644 (file)
@@ -3456,10 +3456,8 @@ static int ocfs2_find_dir_space_el(struct inode *dir, const char *name,
        int blocksize = dir->i_sb->s_blocksize;
 
        status = ocfs2_read_dir_block(dir, 0, &bh, 0);
-       if (status) {
-               mlog_errno(status);
+       if (status)
                goto bail;
-       }
 
        rec_len = OCFS2_DIR_REC_LEN(namelen);
        offset = 0;
@@ -3480,10 +3478,9 @@ static int ocfs2_find_dir_space_el(struct inode *dir, const char *name,
                        status = ocfs2_read_dir_block(dir,
                                             offset >> sb->s_blocksize_bits,
                                             &bh, 0);
-                       if (status) {
-                               mlog_errno(status);
+                       if (status)
                                goto bail;
-                       }
+
                        /* move to next block */
                        de = (struct ocfs2_dir_entry *) bh->b_data;
                }