]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
cls_cgroup: Fix crash on module unload
authorHerbert Xu <herbert@gondor.apana.org.au>
Wed, 3 Nov 2010 13:31:05 +0000 (13:31 +0000)
committerAK <andi@firstfloor.org>
Sun, 6 Feb 2011 19:03:38 +0000 (11:03 -0800)
[ Upstream commit c00b2c9e79466d61979cd21af526cc6d5d0ee04f ]

Somewhere along the lines net_cls_subsys_id became a macro when
cls_cgroup is built as a module.  Not only did it make cls_cgroup
completely useless, it also causes it to crash on module unload.

This patch fixes this by removing that macro.

Thanks to Eric Dumazet for diagnosing this problem.

Reported-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Andi Kleen <ak@linux.intel.com>
Reviewed-by: Li Zefan <lizf@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
net/sched/cls_cgroup.c

index 78ef2c5e130ba9224512dd3872d86226b36306f3..08be223fb3dc02c7365f4c94d955fff7171e67b8 100644 (file)
@@ -34,8 +34,6 @@ struct cgroup_subsys net_cls_subsys = {
        .populate       = cgrp_populate,
 #ifdef CONFIG_NET_CLS_CGROUP
        .subsys_id      = net_cls_subsys_id,
-#else
-#define net_cls_subsys_id net_cls_subsys.subsys_id
 #endif
        .module         = THIS_MODULE,
 };