]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
net/9p: fix client code to fail more gracefully on protocol error
authorEric Van Hensbergen <ericvh@gmail.com>
Thu, 14 Jul 2011 00:12:18 +0000 (19:12 -0500)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 7 Nov 2011 21:46:49 +0000 (13:46 -0800)
commit b85f7d92d7bd7e3298159e8b1eed8cb8cbbb0348 upstream.

There was a BUG_ON to protect against a bad id which could be dealt with
more gracefully.

Reported-by: Natalie Orlin <norlin@us.ibm.com>
Signed-off-by: Eric Van Hensbergen <ericvh@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
net/9p/client.c

index 09d4f1e2e4a8cef1974929198e8df452597c40f6..a442612cb37c9522a98cb2a4e377b56d4b31863d 100644 (file)
@@ -230,7 +230,8 @@ struct p9_req_t *p9_tag_lookup(struct p9_client *c, u16 tag)
         * buffer to read the data into */
        tag++;
 
-       BUG_ON(tag >= c->max_tag);
+       if(tag >= c->max_tag)
+               return NULL;
 
        row = tag / P9_ROW_MAXTAG;
        col = tag % P9_ROW_MAXTAG;