]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
crypto: crypto4xx - fix error return code
authorPeter Senna Tschudin <peter.senna@gmail.com>
Mon, 17 Sep 2012 17:28:27 +0000 (19:28 +0200)
committerHerbert Xu <herbert@gondor.apana.org.au>
Thu, 27 Sep 2012 05:32:15 +0000 (13:32 +0800)
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/amcc/crypto4xx_core.c

index 802e85102c327c7d86d56904c13eadcee1d3287f..f88e3d8f6b647a3275a78506008b4c8eaf92b6e8 100644 (file)
@@ -1226,6 +1226,7 @@ static int __init crypto4xx_probe(struct platform_device *ofdev)
        core_dev->dev->ce_base = of_iomap(ofdev->dev.of_node, 0);
        if (!core_dev->dev->ce_base) {
                dev_err(dev, "failed to of_iomap\n");
+               rc = -ENOMEM;
                goto err_iomap;
        }