]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
team: fix checks in team_get_first_port_txable_rcu()
authorJiri Pirko <jiri@resnulli.us>
Sat, 8 Jun 2013 13:00:55 +0000 (15:00 +0200)
committerDavid S. Miller <davem@davemloft.net>
Wed, 12 Jun 2013 07:56:27 +0000 (00:56 -0700)
should be checked if "cur" is txable, not "port".

Introduced by commit 6e88e1357c "team: use function team_port_txable()
for determing enabled and up port"

Signed-off-by: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/linux/if_team.h

index 4474557904f69eef849b329b41b91ba4f72bb678..16fae6436d0ed150fe5947683c647e7ae8b1d9c4 100644 (file)
@@ -249,12 +249,12 @@ team_get_first_port_txable_rcu(struct team *team, struct team_port *port)
                return port;
        cur = port;
        list_for_each_entry_continue_rcu(cur, &team->port_list, list)
-               if (team_port_txable(port))
+               if (team_port_txable(cur))
                        return cur;
        list_for_each_entry_rcu(cur, &team->port_list, list) {
                if (cur == port)
                        break;
-               if (team_port_txable(port))
+               if (team_port_txable(cur))
                        return cur;
        }
        return NULL;