]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
mpt2sas: issue_reset is uninitialized
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 4 Dec 2014 10:56:10 +0000 (13:56 +0300)
committerChristoph Hellwig <hch@lst.de>
Fri, 9 Jan 2015 14:44:22 +0000 (15:44 +0100)
The "issue_reset" variable can be used uninitialized.  It should be set
to false at the start.

Also I cleaned up the types by using bool.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Sreekanth Reddy <Sreekanth.Reddy@avagotech.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/scsi/mpt2sas/mpt2sas_base.c

index 58e45216d1ecaaf56597d8caf751540f8ebd0f69..3fb01d1883c65834dd12aa6f2b0b04272df5189d 100644 (file)
@@ -3236,7 +3236,7 @@ mpt2sas_base_sas_iounit_control(struct MPT2SAS_ADAPTER *ioc,
        u16 smid;
        u32 ioc_state;
        unsigned long timeleft;
-       u8 issue_reset;
+       bool issue_reset = false;
        int rc;
        void *request;
        u16 wait_state_count;
@@ -3300,7 +3300,7 @@ mpt2sas_base_sas_iounit_control(struct MPT2SAS_ADAPTER *ioc,
                _debug_dump_mf(mpi_request,
                    sizeof(Mpi2SasIoUnitControlRequest_t)/4);
                if (!(ioc->base_cmds.status & MPT2_CMD_RESET))
-                       issue_reset = 1;
+                       issue_reset = true;
                goto issue_host_reset;
        }
        if (ioc->base_cmds.status & MPT2_CMD_REPLY_VALID)
@@ -3341,7 +3341,7 @@ mpt2sas_base_scsi_enclosure_processor(struct MPT2SAS_ADAPTER *ioc,
        u16 smid;
        u32 ioc_state;
        unsigned long timeleft;
-       u8 issue_reset;
+       bool issue_reset = false;
        int rc;
        void *request;
        u16 wait_state_count;
@@ -3398,7 +3398,7 @@ mpt2sas_base_scsi_enclosure_processor(struct MPT2SAS_ADAPTER *ioc,
                _debug_dump_mf(mpi_request,
                    sizeof(Mpi2SepRequest_t)/4);
                if (!(ioc->base_cmds.status & MPT2_CMD_RESET))
-                       issue_reset = 1;
+                       issue_reset = true;
                goto issue_host_reset;
        }
        if (ioc->base_cmds.status & MPT2_CMD_REPLY_VALID)