skd: Fix out of array boundary access

When enabling MSI-X, interrupts are requested for SKD_MAX_MSIX_COUNT
entries in skdev->msix_entries array, while the number of actually
allocated entries is skdev->msix_count. This might lead to an out of
boundary access in case number of allocated entries is less than
SKD_MAX_MSIX_COUNT. This update fixes the described misbehaviour.

Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Cc: linux-pci@vger.kernel.org
Signed-off-by: Jens Axboe <axboe@fb.com>

diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c
index eb6e1e0e8db25f78f2d2407e0d54dafc2a2b9583..3fa0918ddaf8e77f8aa43f691112b0145dafb719 100644 (file)
--- a/drivers/block/skd_main.c
+++ b/drivers/block/skd_main.c
@@ -3989,7 +3989,7 @@ static int skd_acquire_msix(struct skd_device *skdev)
        }
 
        /* Enable MSI-X vectors for the base queue */
-       for (i = 0; i < SKD_MAX_MSIX_COUNT; i++) {
+       for (i = 0; i < skdev->msix_count; i++) {
                qentry = &skdev->msix_entries[i];
                snprintf(qentry->isr_name, sizeof(qentry->isr_name),
                         "%s%d-msix %s", DRV_NAME, skdev->devno,