]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
staging/csr: clean coding style in uf_start_thread
authorDevendra Naga <develkernel412222@gmail.com>
Sat, 4 Aug 2012 07:16:38 +0000 (13:01 +0545)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 14 Aug 2012 01:57:43 +0000 (18:57 -0700)
in bh.c the function uf_start_thread needed a coding style fixes.

The following fixes:

* fix no space at the start of line
* fix over 80 character lines
* fix no brace needed for single statement blocks (if..else or for and while)
* use tabs instead of 4 spaces at the start of every line

Cc: Mikko Virkkilä <mikko.virkkila@bluegiga.com>
Cc: Lauri Hintsala <Lauri.Hintsala@bluegiga.com>
Cc: Riku Mettälä <riku.mettala@bluegiga.com>
Cc: Veli-Pekka Peltola <veli-pekka.peltola@bluegiga.com>
Signed-off-by: Devendra Naga <develkernel412222@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/csr/bh.c

index b089c28d56109313aff4fdc0f75fc827f4b61ca1..2b7c4c09d5f7c3e17c71ed0c378c2518d1812cc2 100644 (file)
  *      0 on success or else a Linux error code.
  * ---------------------------------------------------------------------------
  */
-int
-uf_start_thread(unifi_priv_t *priv, struct uf_thread *thread, int (*func)(void *))
+int uf_start_thread(unifi_priv_t *priv,
+                   struct uf_thread *thread, int (*func)(void *))
 {
-    if (thread->thread_task != NULL) {
-        unifi_error(priv, "%s thread already started\n", thread->name);
-        return 0;
-    }
-
-    /* Start the kernel thread that handles all h/w accesses. */
-    thread->thread_task = kthread_run(func, priv, "%s", thread->name);
-    if (IS_ERR(thread->thread_task)) {
-        return PTR_ERR(thread->thread_task);
-    }
-
-    /* Module parameter overides the thread priority */
-    if (bh_priority != -1) {
-        if (bh_priority >= 0 && bh_priority <= MAX_RT_PRIO) {
-            struct sched_param param;
-            priv->bh_thread.prio = bh_priority;
-            unifi_trace(priv, UDBG1, "%s thread (RT) priority = %d\n",
-                        thread->name, bh_priority);
-            param.sched_priority = bh_priority;
-            sched_setscheduler(thread->thread_task, SCHED_FIFO, &param);
-        } else if (bh_priority > MAX_RT_PRIO && bh_priority <= MAX_PRIO) {
-            priv->bh_thread.prio = bh_priority;
-            unifi_trace(priv, UDBG1, "%s thread priority = %d\n",
-                        thread->name, PRIO_TO_NICE(bh_priority));
-            set_user_nice(thread->thread_task, PRIO_TO_NICE(bh_priority));
-        } else {
-            priv->bh_thread.prio = DEFAULT_PRIO;
-            unifi_warning(priv, "%s thread unsupported (%d) priority\n",
-                          thread->name, bh_priority);
-        }
-    } else {
-        priv->bh_thread.prio = DEFAULT_PRIO;
-    }
-    unifi_trace(priv, UDBG2, "Started %s thread\n", thread->name);
-
-    return 0;
+       if (thread->thread_task != NULL) {
+               unifi_error(priv, "%s thread already started\n", thread->name);
+               return 0;
+       }
+
+       /* Start the kernel thread that handles all h/w accesses. */
+       thread->thread_task = kthread_run(func, priv, "%s", thread->name);
+       if (IS_ERR(thread->thread_task))
+               return PTR_ERR(thread->thread_task);
+
+       /* Module parameter overides the thread priority */
+       if (bh_priority != -1) {
+               if (bh_priority >= 0 && bh_priority <= MAX_RT_PRIO) {
+                       struct sched_param param;
+                       priv->bh_thread.prio = bh_priority;
+                       unifi_trace(priv, UDBG1,
+                               "%s thread (RT) priority = %d\n",
+                               thread->name, bh_priority);
+                       param.sched_priority = bh_priority;
+                       sched_setscheduler(thread->thread_task,
+                                          SCHED_FIFO, &param);
+               } else if (bh_priority > MAX_RT_PRIO &&
+                          bh_priority <= MAX_PRIO) {
+                       priv->bh_thread.prio = bh_priority;
+                       unifi_trace(priv, UDBG1, "%s thread priority = %d\n",
+                                       thread->name,
+                                       PRIO_TO_NICE(bh_priority));
+                       set_user_nice(thread->thread_task,
+                                     PRIO_TO_NICE(bh_priority));
+               } else {
+                       priv->bh_thread.prio = DEFAULT_PRIO;
+                       unifi_warning(priv,
+                                     "%s thread unsupported (%d) priority\n",
+                                     thread->name, bh_priority);
+               }
+       } else
+               priv->bh_thread.prio = DEFAULT_PRIO;
+       unifi_trace(priv, UDBG2, "Started %s thread\n", thread->name);
+
+       return 0;
 } /* uf_start_thread() */
 
 
@@ -88,8 +92,7 @@ uf_start_thread(unifi_priv_t *priv, struct uf_thread *thread, int (*func)(void *
  *
  * ---------------------------------------------------------------------------
  */
-    void
-uf_stop_thread(unifi_priv_t *priv, struct uf_thread *thread)
+void uf_stop_thread(unifi_priv_t *priv, struct uf_thread *thread)
 {
     if (!thread->thread_task) {
         unifi_notice(priv, "%s thread is already stopped\n", thread->name);