]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
cpufreq: exynos: Fix unsigned variable being checked for negative value
authorSachin Kamat <sachin.kamat@linaro.org>
Fri, 25 Jan 2013 18:18:09 +0000 (10:18 -0800)
committerKukjin Kim <kgene.kim@samsung.com>
Fri, 25 Jan 2013 18:18:09 +0000 (10:18 -0800)
exynos_cpufreq_scale function returns signed value which was
assigned to an unsigned variable and checked for negative value which
is always false. Hence make it signed.

Fixes the following smatch warnings:
drivers/cpufreq/exynos-cpufreq.c:83 exynos_cpufreq_scale() warn: unsigned 'old_index' is never less than zero.
drivers/cpufreq/exynos-cpufreq.c:89 exynos_cpufreq_scale() warn: unsigned 'index' is never less than zero.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
drivers/cpufreq/exynos-cpufreq.c

index 0840358bf3bc4b13e8c4b30bb9e3a37fb5efba77..c8c7653a6033f3ffd30949e7367c77bd1213633b 100644 (file)
@@ -65,7 +65,7 @@ static int exynos_cpufreq_scale(unsigned int target_freq)
        struct cpufreq_policy *policy = cpufreq_cpu_get(0);
        unsigned int arm_volt, safe_arm_volt = 0;
        unsigned int mpll_freq_khz = exynos_info->mpll_freq_khz;
-       unsigned int index, old_index;
+       int index, old_index;
        int ret = 0;
 
        freqs.old = policy->cur;