]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
drbd: drbd_send_b_ack(): Return void: the result is never used
authorAndreas Gruenbacher <agruen@linbit.com>
Wed, 16 Mar 2011 00:25:28 +0000 (01:25 +0100)
committerPhilipp Reisner <philipp.reisner@linbit.com>
Thu, 8 Nov 2012 15:44:37 +0000 (16:44 +0100)
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
drivers/block/drbd/drbd_int.h
drivers/block/drbd/drbd_main.c

index b82ef8809130269941ee8f84d508e74a6767729e..354c9ddb09d0a036790236133ec29fec5ab35931 100644 (file)
@@ -1181,8 +1181,8 @@ extern int conn_send_cmd(struct drbd_tconn *tconn, int vnr, struct drbd_socket *
 extern int conn_send_cmd2(struct drbd_tconn *tconn, enum drbd_packet cmd,
                          char *data, size_t size);
 extern int drbd_send_sync_param(struct drbd_conf *mdev);
-extern int drbd_send_b_ack(struct drbd_conf *mdev, u32 barrier_nr,
-                       u32 set_size);
+extern void drbd_send_b_ack(struct drbd_conf *mdev, u32 barrier_nr,
+                           u32 set_size);
 extern int drbd_send_ack(struct drbd_conf *, enum drbd_packet,
                         struct drbd_peer_request *);
 extern int drbd_send_ack_rp(struct drbd_conf *mdev, enum drbd_packet cmd,
index c91450260d8e952200fcb8126ff16d5924637a2d..5bff744897f314ac1a8bc07f1b8480611134ea65 100644 (file)
@@ -1227,19 +1227,15 @@ int drbd_send_bitmap(struct drbd_conf *mdev)
        drbd_put_data_sock(mdev->tconn);
        return err;
 }
-
-int drbd_send_b_ack(struct drbd_conf *mdev, u32 barrier_nr, u32 set_size)
+void drbd_send_b_ack(struct drbd_conf *mdev, u32 barrier_nr, u32 set_size)
 {
-       int ok;
        struct p_barrier_ack p;
 
        p.barrier  = barrier_nr;
        p.set_size = cpu_to_be32(set_size);
 
-       if (mdev->state.conn < C_CONNECTED)
-               return false;
-       ok = !drbd_send_cmd(mdev, &mdev->tconn->meta, P_BARRIER_ACK, &p.head, sizeof(p));
-       return ok;
+       if (mdev->state.conn >= C_CONNECTED)
+               drbd_send_cmd(mdev, &mdev->tconn->meta, P_BARRIER_ACK, &p.head, sizeof(p));
 }
 
 /**