]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
HID: hid-sensor-hub: fix duplicate sysfs entry error
authorSrinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Fri, 6 Dec 2013 00:34:25 +0000 (16:34 -0800)
committerJiri Kosina <jkosina@suse.cz>
Mon, 9 Dec 2013 14:46:09 +0000 (15:46 +0100)
Fix kernel warning and failure to register sensor hub devices with MFD.  Now
many devices has in-built sensor hubs. So by default this HID hub, is properly
parsed and register individual sensors as platform device using MFD framework.
But if a second sensor hub is attached via USB, which has same sensors, it will
result in kernel warning and failure to register MFD cell as the platform
device sysfs file name will be same as created by in-built sensor hubs. This
patch sets MFD cell id to PLATFORM_DEVID_AUTO. In this way there will never be
duplicate sysfs file names.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-sensor-hub.c

index a184e1921c11190ffce1033e5b7d4f512d55f798..8af2d906db6ce95be0c4c112f04fe754be313dd0 100644 (file)
@@ -572,6 +572,8 @@ static int sensor_hub_probe(struct hid_device *hdev,
                                        ret = -ENOMEM;
                                        goto err_free_names;
                        }
+                       sd->hid_sensor_hub_client_devs[
+                               sd->hid_sensor_client_cnt].id = PLATFORM_DEVID_AUTO;
                        sd->hid_sensor_hub_client_devs[
                                sd->hid_sensor_client_cnt].name = name;
                        sd->hid_sensor_hub_client_devs[