]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
[ACPI] fix acpi_os_wait_sempahore() finite timeout case (AE_TIME warning)
authorYu Luming <luming.yu@intel.com>
Sat, 31 Dec 2005 06:45:00 +0000 (01:45 -0500)
committerLen Brown <len.brown@intel.com>
Tue, 3 Jan 2006 21:27:21 +0000 (16:27 -0500)
Before this fix, the finite timeout case
behaved like the no-timeout (trylock) case.

http://bugzilla.kernel.org/show_bug.cgi?id=4588

Signed-off-by: Luming Yu <luming.yu@intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>
drivers/acpi/osl.c

index e3cd0b16031ad32c70ee1b47516c23b02856cbcb..8653dac01a76127b8485d5a07836a124c3d0d759 100644 (file)
@@ -836,7 +836,7 @@ acpi_status acpi_os_wait_semaphore(acpi_handle handle, u32 units, u16 timeout)
                        static const int quantum_ms = 1000 / HZ;
 
                        ret = down_trylock(sem);
-                       for (i = timeout; (i > 0 && ret < 0); i -= quantum_ms) {
+                       for (i = timeout; (i > 0 && ret != 0); i -= quantum_ms) {
                                schedule_timeout_interruptible(1);
                                ret = down_trylock(sem);
                        }