]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
[media] rc: ene_ir: fix potential double free in ene_probe()
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>
Tue, 9 Apr 2013 08:47:42 +0000 (05:47 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Mon, 15 Apr 2013 00:38:17 +0000 (21:38 -0300)
Since rc_unregister_device() frees its argument, the subsequently
call to rc_free_device() on the same variable will cause a double
free bug. Fix by set argument to NULL, thus when fall through to
rc_free_device(), nothing will be done there.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/rc/ene_ir.c

index ee6c984cade248613e17764963aeb93a809d2e9d..ed184f68c17c5ed39c35e342018ad281eb5e23d6 100644 (file)
@@ -1098,6 +1098,7 @@ exit_release_hw_io:
        release_region(dev->hw_io, ENE_IO_SIZE);
 exit_unregister_device:
        rc_unregister_device(rdev);
+       rdev = NULL;
 exit_free_dev_rdev:
        rc_free_device(rdev);
        kfree(dev);