]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
usb: gadget: f_subset: fix missing unlock on error in geth_alloc()
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>
Tue, 18 Jun 2013 03:40:55 +0000 (11:40 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 18 Jun 2013 17:50:08 +0000 (10:50 -0700)
Add the missing unlock before return from function geth_alloc()
in the error handling case.

Introduced by commit 02832e56f88a981474ee4c7c141f46fc1b4454f4.
(usb: gadget: f_subset: add configfs support)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/gadget/f_subset.c

index fbc7a24942e4a2335bf65b6972c856a27dfd4443..5601e1d96c4fabd7f8a44bc80703080495fba56a 100644 (file)
@@ -548,6 +548,7 @@ static struct usb_function *geth_alloc(struct usb_function_instance *fi)
                                          sizeof(geth->ethaddr));
        if (status < 12) {
                kfree(geth);
+               mutex_unlock(&opts->lock);
                return ERR_PTR(-EINVAL);
        }
        geth_string_defs[1].s = geth->ethaddr;