]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
staging: lustre: ptlrpc: Replace OBD_CPT_ALLOC etc by kzalloc_node
authorJulia Lawall <Julia.Lawall@lip6.fr>
Sun, 3 May 2015 13:21:42 +0000 (15:21 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 8 May 2015 07:23:57 +0000 (09:23 +0200)
Replace OBD_CPT_ALLOC, OBD_CPT_ALLOC_PTR, and OBD_CPT_ALLOC_GFP by
corresponding calls to kzalloc_node.  The semantic patch for the
OBD_CPT_ALLOC case is as follows: (http://coccinelle.lip6.fr/).

// <smpl>
@@ expression ptr,cptab,cpt,size; @@
- OBD_CPT_ALLOC(ptr, cptab, cpt, size)
+ ptr = kzalloc_node(size, GFP_NOFS, cfs_cpt_spread_node(cptab, cpt))
// </smpl>

Note that the original OBD macros would check if the cptab argument was
NULL and fall back on kzalloc in that case.  Oleg Drokin argues that this
test is not needed because the code containing these calls is only invoked
after initialization has been completed, in which case the possible cptab
arguments are not NULL.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/lustre/lustre/ptlrpc/nrs.c

index 68c754f67d2d1e8e189b717a05d23d6fbba7e0e6..63a05f4a902da15add30b81bd025c7fc01c99a2b 100644 (file)
@@ -746,8 +746,9 @@ static int nrs_policy_register(struct ptlrpc_nrs *nrs,
        LASSERT(desc->pd_ops->op_req_dequeue != NULL);
        LASSERT(desc->pd_compat != NULL);
 
-       OBD_CPT_ALLOC_GFP(policy, svcpt->scp_service->srv_cptable,
-                         svcpt->scp_cpt, sizeof(*policy), GFP_NOFS);
+       policy = kzalloc_node(sizeof(*policy), GFP_NOFS,
+                       cfs_cpt_spread_node(svcpt->scp_service->srv_cptable,
+                                           svcpt->scp_cpt));
        if (policy == NULL)
                return -ENOMEM;
 
@@ -961,9 +962,10 @@ static int nrs_svcpt_setup_locked(struct ptlrpc_service_part *svcpt)
        if (svcpt->scp_service->srv_ops.so_hpreq_handler == NULL)
                goto out;
 
-       OBD_CPT_ALLOC_PTR(svcpt->scp_nrs_hp,
-                         svcpt->scp_service->srv_cptable,
-                         svcpt->scp_cpt);
+       svcpt->scp_nrs_hp =
+               kzalloc_node(sizeof(*svcpt->scp_nrs_hp), GFP_NOFS,
+                       cfs_cpt_spread_node(svcpt->scp_service->srv_cptable,
+                                           svcpt->scp_cpt));
        if (svcpt->scp_nrs_hp == NULL) {
                rc = -ENOMEM;
                goto out;